feat: accessibility tests #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried with node 20.18.0 on Windows 11 with "yarn" + "yarn storybook", and then when storybook was running, "yarn test-storybook" in another terminal. Needed to install web browsers for testing first though, so "yarn playwright install" and then "yarn test-storybook" went through. All tests passed: All tests passed (Click to expand)There were some warnings given by See the "All tests passed (Click to expand)" for all the warnings. |
.storybook/test-runner.js
Outdated
| await injectAxe(page); | ||
| }, | ||
| postRender: async (page) => { | ||
| // after the story has been rendered rn AXE checksonly on root not the whole page |
There was a problem hiding this comment.
Suggested change
| // after the story has been rendered rn AXE checksonly on root not the whole page | |
| // after the story has been rendered, run AXE checks only on root, not the whole page |
public/mockServiceWorker.js
Outdated
Comment on lines
11
to
13
| const INTEGRITY_CHECKSUM = '3d6b9f06410d179a7f7404d4bf4c3c70' | ||
| const activeClientIds = new Set() | ||
| const INTEGRITY_CHECKSUM = '3d6b9f06410d179a7f7404d4bf4c3c70'; | ||
| const activeClientIds = new Set(); | ||
|
|
There was a problem hiding this comment.
This file starts with:
/* eslint-disable */
/* tslint:disable */
/**
* Mock Service Worker (1.2.3).
* @see https://github.com/mswjs/msw
* - Please do NOT modify this file.
* - Please do NOT serve this file on production.
*/This file should probably be completely ignored by prettier also so it doesn't try to change anything in this file.
|
fixed the jest warnings |
karisal-anders
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Looks ok otherwise, only the jest-haste-map warnings still at the beginning of "test-storybook"'s output i.e.
$ yarn test-storybook
yarn run v1.22.22
$ test-storybook
jest-haste-map: duplicate manual mock found: articles.mock.d
The following files share their name; please delete one of them:
* <rootDir>\dist\src\core\archiveSearchPageContent\__mocks__\articles.mock.d.ts
* <rootDir>\dist\cjs\src\core\archiveSearchPageContent\__mocks__\articles.mock.d.ts
jest-haste-map: duplicate manual mock found: categories.mock.d
The following files share their name; please delete one of them:
* <rootDir>\dist\src\core\archiveSearchPageContent\__mocks__\categories.mock.d.ts
* <rootDir>\dist\cjs\src\core\archiveSearchPageContent\__mocks__\categories.mock.d.ts
...
"yarn build" + "yarn storybook" in one terminal, then "yarn test-storybook" -> jest-haste-map warnings went away. So basically "yarn build" helped with removing the jest-haste-map warnings when running the storybook tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
Closes
HCRC-123:
Related
Testing
Automated tests
Manual testing
Screenshots
Additional notes