Fix infinite loop with layout cards module #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomakela
force-pushed
the
HCRC-106-fix-inifinite-loop-on-cards-module
branch
from
c1fa7da to
39b24a6
Compare
nikomakela
force-pushed
the
HCRC-106-fix-inifinite-loop-on-cards-module
branch
2 times, most recently
from
629bf2d to
fc5aff3
Compare
melniiv
approved these changes
Nov 7, 2023
HCRC-106 HCRC-108 Use a crypto lib to create an unique hash key. Add a missing key-property to layout cards module, steps module and the modules in the pageContent component.
HCRC-106 HCRC-108
nikomakela
force-pushed
the
HCRC-106-fix-inifinite-loop-on-cards-module
branch
from
fc5aff3 to
f6c8721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HCRC-106 HCRC-108.
When a layout cards module wsa used, the CMS pages went to an infite rerendering loop in apps.
This can be tested in Liikunta test-CMS-env with
/fi/pages/moduulitesti/Also fixed a style filling bug in Card-module:
Broken:
Fixed:
Mobile: