fix: handle errors while parsing dates in filters #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicobav
force-pushed
the
HAUKI-564/date-filter-error-handling
branch
from
a02111c to
eb45e5d
Compare
There were error, handling the returned value of the date string parser. Problem was that the parser could return None value which was compared against other None or date which obviously does not compute. Solution to this is to fail early on the parser function and handle the error correctly where the parser function is used. This lead to writing error handling to the MaybeRelativeDateField since the viewset using the function was correctly handling errors (just not the None values). Before this, when giving badly formatted date parameter in the dateperiod end would have been okay and all the periods would be returned - not anymore, now it returns a validation error. Refs HAUKI-564
nicobav
force-pushed
the
HAUKI-564/date-filter-error-handling
branch
from
eb45e5d to
edb49e7
Compare
|
|
HAUKI-API branch is deployed to platta: https://hauki-pr260.api.dev.hel.ninja 🚀🚀🚀 |
api tests result is success for https://hauki-pr260.api.dev.hel.ninja 😆🎉🎉🎉 |
danipran
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were error, handling returned value of the date string parser. Problem was that the parser could return None value which was compared against other None or date which obviously does not compute.
Solution to this is to fail early on the parser function and handle the error correctly where the parser function is used. This lead to writing error handling to the MaybeRelativeDateField since the viewset using the function was correctly handling errors (just not the None values).
Before this, when giving badly formatted date parameter in the dateperiod end would have been okay and all the periods would be returned - not anymore, now it returns a validation error.
Refs HAUKI-564