-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumbs: implemenation to the apps #651
Conversation
2b4b6cf
to
7ea343a
Compare
6da4e84
to
108296e
Compare
LIIKUNTA-611
Federation Router branch is deployed to platta: https://events-graphql-federation-hobbies-pr651.dev.hel.ninja 🚀🚀🚀 |
Federation Router branch is deployed to platta: https://events-graphql-federation-events-pr651.dev.hel.ninja 🚀🚀🚀 |
Federation Router branch is deployed to platta: https://events-graphql-federation-sports-pr651.dev.hel.ninja 🚀🚀🚀 |
7ea343a
to
2c73d81
Compare
Events-Helsinki branch is deployed to platta: https://tapahtumat-pr651.dev.hel.ninja 🚀🚀🚀 |
Sports-Helsinki branch is deployed to platta: https://liikunta-pr651.dev.hel.ninja 🚀🚀🚀 |
Events-Helsinki branch is deployed to platta: https://tapahtumat-pr651.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://tapahtumat-pr651.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://liikunta-pr651.dev.hel.ninja 😆🎉🎉🎉 |
Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr651.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://harrastukset-pr651.dev.hel.ninja 😆🎉🎉🎉 |
EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr651.dev.hel.ninja 🚀🚀🚀 |
VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr651.dev.hel.ninja 🚀🚀🚀 |
LIIKUNTA-611. The HDS breadcrumbs are used from HCRC-lib. The dynamic CMS pages and the CMS articles now renders the breadcrumbs that the CMS API offers. The page and article query is defined in the RCHC-lib and the RCHC-lib also takes cares of duplicates links in a list of breadcrumbs, since there could be for example a duplicated root / home. The common-packages package removes some excluded paths, since the `/pages` path is not wanted to be included in the breadcrumbs. Other features added: - Force add the article archive list item in the breadcrumbs of any CMS article page. - Add breadcrumbs to article archive page - Add breadcrumbs to search page - Add breadcrumbs to venue details page - Add breadcrumbs to event and course detail pages - Add breadcrumbs to cookie consent page
2c73d81
to
0ea9ce6
Compare
Quality Gate failedFailed conditions |
Quality Gate failedFailed conditions |
Quality Gate failedFailed conditions |
Quality Gate failedFailed conditions |
Quality Gate failedFailed conditions |
Events-Helsinki branch is deployed to platta: https://tapahtumat-pr651.dev.hel.ninja 🚀🚀🚀 |
Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr651.dev.hel.ninja 🚀🚀🚀 |
Sports-Helsinki branch is deployed to platta: https://liikunta-pr651.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://tapahtumat-pr651.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://liikunta-pr651.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://harrastukset-pr651.dev.hel.ninja 😆🎉🎉🎉 |
VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr651.dev.hel.ninja 🚀🚀🚀 |
EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr651.dev.hel.ninja 🚀🚀🚀 |
NOTE: Depends on router changes of #650 and HCRC-lib changes of City-of-Helsinki/react-helsinki-headless-cms#165
LIIKUNTA-611.
The HDS breadcrumbs are used from HCRC-lib.
The dynamic CMS pages and the CMS articles now renders
the breadcrumbs that the CMS API offers.
The page and article query is defined in the RCHC-lib
and the RCHC-lib also takes cares of duplicates links in a list of
breadcrumbs, since there could be for example a duplicated root / home.
The common-packages package removes some excluded paths, since
the
/pages
path is not wanted to be included in the breadcrumbs.Other features added:
of any CMS article page.
Desktop view of a 3rd level page
The full breadcrumb is visible
Mobile view of a 3rd level page
The parent page is visible in the breadcrumb. The rest of the breadcrumbs are hidden. This feature comes from the HDS.
Translations of the breadcrumbs
The translations are taken care of
Article archive
The article archive has a special breadcrumbs handling because the articles does not have the breadcrumbs feature in CMS yet.
In Swedish
Articles
The article has a special breadcrumbs handling because the articles does not have the breadcrumbs feature in CMS yet. The archive is added in the breadcrumbs manually.
Search page
The breadcrumbs are fetched from the search cms page
Swedish -- the translations are taken care of
Venue details
Event and course details
Smaller view
Smallest view
in Swedish
Cookie consent page