Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs: implemenation to the apps #651

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

nikomakela
Copy link
Contributor

@nikomakela nikomakela commented Mar 5, 2024

NOTE: Depends on router changes of #650 and HCRC-lib changes of City-of-Helsinki/react-helsinki-headless-cms#165

LIIKUNTA-611.

The HDS breadcrumbs are used from HCRC-lib.

The dynamic CMS pages and the CMS articles now renders
the breadcrumbs that the CMS API offers.

The page and article query is defined in the RCHC-lib
and the RCHC-lib also takes cares of duplicates links in a list of
breadcrumbs, since there could be for example a duplicated root / home.

The common-packages package removes some excluded paths, since
the /pages path is not wanted to be included in the breadcrumbs.

Other features added:

  • Force add the article archive list item in the breadcrumbs
    of any CMS article page.
  • Add breadcrumbs to article archive page
  • Add breadcrumbs to search page
  • Add breadcrumbs to venue details page
  • Add breadcrumbs to event and course detail pages
  • Add breadcrumbs to cookie consent page

Desktop view of a 3rd level page

The full breadcrumb is visible

image

Mobile view of a 3rd level page

The parent page is visible in the breadcrumb. The rest of the breadcrumbs are hidden. This feature comes from the HDS.

image

Translations of the breadcrumbs

The translations are taken care of

image image image

Article archive

The article archive has a special breadcrumbs handling because the articles does not have the breadcrumbs feature in CMS yet.

image

In Swedish

image

Articles

The article has a special breadcrumbs handling because the articles does not have the breadcrumbs feature in CMS yet. The archive is added in the breadcrumbs manually.

image image

Search page

The breadcrumbs are fetched from the search cms page

image

Swedish -- the translations are taken care of

image

Venue details

image image image

Event and course details

image

Smaller view

image

Smallest view

image

in Swedish

image

Cookie consent page

image image

@nikomakela nikomakela changed the title feat: cms pages (dynamic page and article) uses the breadcrumbs from cms Breadcrumbs: implemenation to the apps Mar 5, 2024
@nikomakela nikomakela requested review from karisal-anders and melniiv and removed request for karisal-anders March 5, 2024 11:41
@nikomakela nikomakela force-pushed the LIIKUNTA-611-cms-breadcrumb branch from 2b4b6cf to 7ea343a Compare March 5, 2024 12:07
@nikomakela nikomakela requested a review from jakezu March 5, 2024 12:31
@nikomakela nikomakela force-pushed the LIIKUNTA-611-cms-schema-updates branch from 6da4e84 to 108296e Compare March 6, 2024 08:16
@nikomakela nikomakela changed the base branch from LIIKUNTA-611-cms-schema-updates to main March 6, 2024 14:51
@terovirtanen
Copy link
Contributor

Federation Router branch is deployed to platta: https://events-graphql-federation-hobbies-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Federation Router branch is deployed to platta: https://events-graphql-federation-events-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Federation Router branch is deployed to platta: https://events-graphql-federation-sports-pr651.dev.hel.ninja 🚀🚀🚀

@nikomakela nikomakela force-pushed the LIIKUNTA-611-cms-breadcrumb branch from 7ea343a to 2c73d81 Compare March 6, 2024 15:01
@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr651.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr651.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr651.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr651.dev.hel.ninja 🚀🚀🚀

LIIKUNTA-611.

The HDS breadcrumbs are used from HCRC-lib.

The dynamic CMS pages and the CMS articles now renders
the breadcrumbs that the CMS API offers.

The page and article query is defined in the RCHC-lib
and the RCHC-lib also takes cares of duplicates links in a list of
breadcrumbs, since there could be for example a duplicated root / home.

The common-packages package removes some excluded paths, since
the `/pages` path is not wanted to be included in the breadcrumbs.

Other features added:
- Force add the article archive list item in the breadcrumbs
of any CMS article page.
- Add breadcrumbs to article archive page
- Add breadcrumbs to search page
- Add breadcrumbs to venue details page
- Add breadcrumbs to event and course detail pages
- Add breadcrumbs to cookie consent page
@nikomakela nikomakela force-pushed the LIIKUNTA-611-cms-breadcrumb branch from 2c73d81 to 0ea9ce6 Compare March 6, 2024 20:49
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
63.8% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Coverage on New Code (required ≥ 65%)
4.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.1% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr651.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr651.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr651.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr651.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr651.dev.hel.ninja 🚀🚀🚀

@nikomakela nikomakela merged commit c250564 into main Mar 6, 2024
113 of 114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants