refactor: improve Askem api key api config

City-of-Helsinki · Nov 6, 2023 · 47469db · 47469db
1 parent eceb908
commit 47469db
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 21 deletions.
diff --git a/apps/events-helsinki/src/domain/app/AppConfig.ts b/apps/events-helsinki/src/domain/app/AppConfig.ts
@@ -173,16 +173,15 @@ class AppConfig {
   }
 
   static askemFeedbackConfiguration(locale: 'en' | 'fi' | 'sv') {
+    const askemApiKeyByLocale: Record<typeof locale, string | undefined> = {
+      fi: process.env.NEXT_PUBLIC_ASKEM_API_KEY_FI,
+      sv: process.env.NEXT_PUBLIC_ASKEM_API_KEY_SV,
+      en: process.env.NEXT_PUBLIC_ASKEM_API_KEY_EN,
+    };
     const askemEnabled = process.env.NEXT_PUBLIC_ASKEM_ENABLED;
-    let askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_FI;
-    if (locale === 'en') {
-      askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_EN;
-    } else if (locale === 'sv') {
-      askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_SV;
-    }
     return {
       disabled: !parseEnvValue(askemEnabled),
-      apiKey: askemApiKey as string,
+      apiKey: askemApiKeyByLocale[locale] ?? '',
     };
   }
 

diff --git a/apps/hobbies-helsinki/src/domain/app/AppConfig.ts b/apps/hobbies-helsinki/src/domain/app/AppConfig.ts
@@ -173,16 +173,15 @@ class AppConfig {
   }
 
   static askemFeedbackConfiguration(locale: 'en' | 'fi' | 'sv') {
+    const askemApiKeyByLocale: Record<typeof locale, string | undefined> = {
+      fi: process.env.NEXT_PUBLIC_ASKEM_API_KEY_FI,
+      sv: process.env.NEXT_PUBLIC_ASKEM_API_KEY_SV,
+      en: process.env.NEXT_PUBLIC_ASKEM_API_KEY_EN,
+    };
     const askemEnabled = process.env.NEXT_PUBLIC_ASKEM_ENABLED;
-    let askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_FI;
-    if (locale === 'en') {
-      askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_EN;
-    } else if (locale === 'sv') {
-      askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_SV;
-    }
     return {
       disabled: !parseEnvValue(askemEnabled),
-      apiKey: askemApiKey as string,
+      apiKey: askemApiKeyByLocale[locale] ?? '',
     };
   }
 

diff --git a/apps/sports-helsinki/src/domain/app/AppConfig.ts b/apps/sports-helsinki/src/domain/app/AppConfig.ts
@@ -172,16 +172,15 @@ class AppConfig {
   }
 
   static askemFeedbackConfiguration(locale: 'en' | 'fi' | 'sv') {
+    const askemApiKeyByLocale: Record<typeof locale, string | undefined> = {
+      fi: process.env.NEXT_PUBLIC_ASKEM_API_KEY_FI,
+      sv: process.env.NEXT_PUBLIC_ASKEM_API_KEY_SV,
+      en: process.env.NEXT_PUBLIC_ASKEM_API_KEY_EN,
+    };
     const askemEnabled = process.env.NEXT_PUBLIC_ASKEM_ENABLED;
-    let askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_FI;
-    if (locale === 'en') {
-      askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_EN;
-    } else if (locale === 'sv') {
-      askemApiKey = process.env.NEXT_PUBLIC_ASKEM_API_KEY_SV;
-    }
     return {
       disabled: !parseEnvValue(askemEnabled),
-      apiKey: askemApiKey as string,
+      apiKey: askemApiKeyByLocale[locale] ?? '',
     };
   }