Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP 0880 spider chi ssa 20 #989
base: main
Are you sure you want to change the base?
WIP 0880 spider chi ssa 20 #989
Changes from 23 commits
79ae693
10e8b43
d2aa321
fffba24
d659e40
546c57c
1a0c2aa
a2d01e3
d36a9bc
a45bdbb
9546938
96379d6
a505b94
2027052
29e56be
6978f39
f1b5bf6
7eddea7
89b9a0a
61b0364
c240983
b311059
27101f0
a595f4e
bf6d2ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try and parse these from the section on the right and attempt to match them to meetings. You can see an example of this in
chi_il_medical_district
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to accomplish this. I'm afraid I may have chosen a less than optimal logic if including the links should be involved,
(We had a small conversation about this on Slack, irrc).
I will try and see how this option can be factored in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another item that's worth mentioning: The links on the right do not have dates posted on them but rather "1st quarter 2018" , "1st quarter 2019" and so on.
The meetings posted for 2019 ("current" at the time, I assume) were in June and July - not necessarily corresponding to a quarterly schedule, that could be a challenge, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As they've added 2021 meetings, things changed up a bit. Before the change, all the meetings took place in recent history, with some of them - having matching links on the right.
Now, there are only future meetings on the left (2021), and everything on the right is past, with no matching meetings on the left (future).
So it's a new challenge, so it seems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjsier With the added 2021 meetings:
A meeting is either current/upcoming without meeting minutes, but with time data or, it's past with meeting minutes and without time data.
What should we do in this case ?
https://www.mpbhba.org/business-resources/
An example to a past meeting link (without time data)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general if the time data isn't present on past meetings we can go with a reasonable default based on the current meetings. It looks like 8am should work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8am works for me. What about the date :) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah missed that, for some of them it looks like the date is in the URL itself, and for the others we might just need to ignore them for now