-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[b] Missing python-dateutil
dependency in deployment mode
#15
Conversation
WalkthroughThe pull request introduces changes to the project's dependency management by adding the Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
python-dateutil
dependency in production mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Pipfile (1)
11-11
: Dependency Addition for Date Util
The addition ofpython-dateutil = "2.8.2"
correctly addresses the missing dependency that was causing production issues, as mentioned in DOC-933 regarding the cron job failures.
- Consideration: Depending on your project's update policies, you might consider specifying a version range (e.g.,
">=2.8.2,<2.9"
) instead of a fixed version to allow for minor patch updates while avoiding breaking changes.
python-dateutil
dependency in production modepython-dateutil
dependency in deployment mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's this PR do?
python-dateutil
dependency in production mode.city-scrapers-caconj
Why are we doing this?
python-dateutil
Summary by CodeRabbit
fix-date-util-dependency
branch.