Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNE-816: Make the project search endpoint to use the teams version one #981

Closed
wants to merge 3 commits into from

Conversation

pacdaemon
Copy link
Contributor

@pacdaemon pacdaemon commented Nov 18, 2024

Citrine Python PR

Description

This is basically #974 without some addition that stretches its goal for the sake of improving the code base but sadly had introduced a dev0. I'll continue with @kroenlein 's proposal later, but I'm playing safe here so we can deliver the value of fixing the ticket issue for the release.

Jira ticket: https://citrine.atlassian.net/browse/PNE-816

For searching for projects in the SDK we were using a team-agnostic endpoint, causing the search to be executed in a broader scope (all of the teams visible to the user). This work switches the endpoint so the search will have the right scope.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@pacdaemon pacdaemon marked this pull request as ready for review November 18, 2024 11:47
@pacdaemon pacdaemon requested a review from a team as a code owner November 18, 2024 11:47
@pacdaemon pacdaemon changed the title bugfix/PNE 816 second attempt PNE-816: Make the project search endpoint to use the teams version one Nov 18, 2024
@pacdaemon
Copy link
Contributor Author

Closing as #980 does this and also handles the boarder change intended by stretching its goal

@pacdaemon pacdaemon closed this Nov 18, 2024
@pacdaemon pacdaemon deleted the bugfix/PNE-816-second-attempt branch November 18, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant