Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOS-XE] Support space in SSID in ShowWlan #838

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

FlavienJP
Copy link

Description

I've made two changes to support SSID with spaces (ex : "My SSID Is Fun") for both commands :

  • show wlan summary
  • show wlan all

And also changed "radio_policy" to optional because it's not used when configured with dnac.

This PR is correctif issue #832

Motivation and Context

A lot of customers are using spaces in their deployments, so it's better to support it :)

Impact (If any)

No negative impact !

Screenshots:

show wlan summary

image

###show wlan all

image

Checklist:

  • I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • All new and existing tests passed.
  • All new code passed compilation.

@FlavienJP FlavienJP requested a review from a team as a code owner March 28, 2024 12:10
@ThomasJRyan
Copy link
Collaborator

The change looks good, put our pipeline is failing. Looks like you need to run make json and upload the file that's generated from that

@FlavienJP
Copy link
Author

The change looks good, put our pipeline is failing. Looks like you need to run make json and upload the file that's generated from that

Added, you can retry the pipeline.

@Taarini
Copy link
Contributor

Taarini commented Apr 3, 2024

Hi @FlavienJP,

Can you please delete the below files using git rm <filename/path_to_filename>

        deleted:    src/genie/libs/parser/cheetah/tests/ShowInterfacesWired/cli/equal/golden_output1_output.py
        deleted:    src/genie/libs/parser/cheetah/tests/ShowInterfacesWired/cli/equal/golden_output1_output.txt
        deleted:    src/genie/libs/parser/cheetah/tests/ShowInterfacesWired/cli/equal/golden_output2_output.py
        deleted:    src/genie/libs/parser/cheetah/tests/ShowInterfacesWired/cli/equal/golden_output3_output.py

These duplicate files are causing pipeline failure. I'm unable to commit to your branch.

@FlavienJP
Copy link
Author

Hello @Taarini, i've removed the requested files (that were not by pushed by myself :)).

@SohanTirpude SohanTirpude merged commit 917c322 into CiscoTestAutomation:master Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants