ISICO-14359: workflow instrumentation added #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charybr
reviewed
Feb 10, 2023
| @@ -169,6 +169,10 @@ public static void recordGauge(String name, long count) { | |||
| gauge(classQualifier, name, count); | |||
| } | |||
There was a problem hiding this comment.
Instead of ENV_DEFAULT_LOG_LEVEL, to enable/disable metrics logging we can use existing property - conductor.metrics-logger.enabled
https://github.com/Netflix/conductor/blob/2ccf09e1a31bf4e5ebf80982199250cf82f50556/CHANGELOG.md#component-configuration
There was a problem hiding this comment.
lets see what others also saying. if debug is enabled, always metrics are added in the log. but if we add a specific parameter then it has to be added as a bender configuration so that it can be edited on editing sts file. not a spring configuration in galaxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often we need to find slowness issues in the code. To find which component is behaving slow, we have to add debug statements and update the cloud with the debug patch. Instead of patching the cloud, we can add the instrumentation code by default with the microservice and enable it when required. When ENV_DEFAULT_LOG_LEVEL is set to debug, metrics logging is also enabled. Once in 30 seconds metrics values are printed in the log.