[UX2.0] Resolve Issue #296 #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danischm
requested changes
Oct 18, 2024
There was a problem hiding this comment.
It looks like SD-WAN manager always includes unsupported_features in the GET payload, even if it is set to null. To be consist, we don't want TF users to configure empty lists, but rather omit or set it to null. In this case we should therefore make sure that we translate an empty list in the GET response to a null value in state instead of asking users to configure an empty list.
|
@seconroy could you please change it as per Daniel's comment? |
|
@seconroy , I am already working on this as part of another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves Issues #296
Types of Changes
Checklist