Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security policy definition resource and data source #117

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

seconroy
Copy link
Collaborator

@seconroy seconroy commented Dec 4, 2023

Description

Add security policy definition resource and data source,

  1. RESOLVED - Failing to create policy however the create object works when pasted into Postman.

2. DO NOT MERGE - Creates policy however tests fail when requesting the new policy, it seems that the /template/policy/security/ endpoint does not return a definitionId for the created policy.

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@danischm danischm marked this pull request as ready for review January 26, 2024 13:10
@danischm danischm merged commit 6020093 into CiscoDevNet:main Jan 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants