update task health status based on health_status_changed_event #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks again for the great project.
As mentioned in #24 , when using marathon-consul with haproxy-consul , we see tasks added to haproxy before they are healthy.
This PR adds a
HealthCheckResults
field to the Task (already reported by marathon), as well as a conveniencehealthy
flag to make it easier to work with in templates.Tasks health information is updated on receiving
health_status_changed_event
from marathon.healthy
is currently a bool, but in reality it's more of a tri-state (unknown, healthy, unhealthy). currently it will report healthy=false unless there is a successful health check (again makes it easier to work with in templates).I'd love any feedback to making this work better or to better integrate with the existing code.
thanks!
larry