Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple <<includes(file)>> and embedded <<includes(file)>> #737

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Mongey
Copy link

@Mongey Mongey commented Jun 11, 2022

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • Add support for multiple <<includes(file)>> and embedded <<includes(file) >>

Rationale

=========

I see there are cucumber tests to assert this behaviour is not supported, but I would like it to work this way 😄
Usecase: I have a template file in my orb, and rather than embedded the contents directly in my command

 - run: echo 'my-extremely-large-template\nis here' > foo.tmpl

I want to have

- run: echo '<< include(template.tmpl) >>' > foo.tmpl

where template.tmpl is

my-extremely-large-template
is here

Considerations

==============
n/a

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Base: 32.77% // Head: 33.13% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (60b2e04) compared to base (168582f).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 60b2e04 differs from pull request most recent head 4faf29b. Consider uploading reports for the commit 4faf29b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   32.77%   33.13%   +0.35%     
==========================================
  Files          46       47       +1     
  Lines        5415     5489      +74     
==========================================
+ Hits         1775     1819      +44     
- Misses       3387     3402      +15     
- Partials      253      268      +15     
Impacted Files Coverage Δ
process/process.go 100.00% <100.00%> (ø)
api/policy/policy.go 65.86% <0.00%> (-5.44%) ⬇️
cmd/policy/policy.go 77.38% <0.00%> (-1.37%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mongey Mongey force-pushed the master branch 4 times, most recently from 88d1cbb to e61d690 Compare June 15, 2022 18:57
@Mongey Mongey marked this pull request as ready for review June 15, 2022 19:46
@Mongey Mongey requested a review from a team as a code owner June 15, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant