Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: use SetIndent(2) to dump yaml subcommands #677

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zchee
Copy link

@zchee zchee commented Mar 18, 2022

Use SetIndent(2) to dump yaml subcommands.

Normally the indent for yaml is 2 indent, as does the CircleCI document.

@zchee zchee requested a review from a team as a code owner March 18, 2022 20:59
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #677 (03eb272) into master (263902a) will increase coverage by 0.08%.
The diff coverage is 69.76%.

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   27.37%   27.45%   +0.08%     
==========================================
  Files          41       41              
  Lines        4523     4509      -14     
==========================================
  Hits         1238     1238              
+ Misses       3134     3129       -5     
+ Partials      151      142       -9     
Impacted Files Coverage Δ
cmd/config.go 31.48% <16.66%> (ø)
cmd/orb.go 13.78% <27.27%> (+0.06%) ⬆️
cmd/admin.go 57.50% <100.00%> (+2.73%) ⬆️
cmd/build.go 85.71% <100.00%> (ø)
cmd/namespace.go 27.94% <100.00%> (ø)
cmd/query.go 24.32% <100.00%> (ø)
cmd/root.go 51.74% <100.00%> (ø)
cmd/setup.go 49.56% <100.00%> (+2.45%) ⬆️
cmd/step.go 61.90% <100.00%> (ø)
cmd/switch.go 35.71% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263902a...03eb272. Read the comment docs.

@rlegan
Copy link
Contributor

rlegan commented Apr 21, 2023

hey!
thanks for you pr 😄
I don't really understand why you've commented some bunch of code, which I think does not have any link to the issue and the purpose of this PR ?

by the way, is it possible for you to rebase it ? thank you !

Copy link
Contributor

@rlegan rlegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlegan rlegan changed the base branch from main to develop May 9, 2023 09:44
@rlegan rlegan requested review from a team as code owners May 9, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants