Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New parametrizations for external shear and point mass #304

Merged
merged 13 commits into from
Jan 25, 2025

Conversation

ConnorStoneAstro
Copy link
Member

No description provided.

@ConnorStoneAstro ConnorStoneAstro added the feat Features: Introduces a new feature to the codebase label Dec 20, 2024
@ConnorStoneAstro
Copy link
Member Author

Closes #196

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 95.96774% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (ea277ed) to head (3ea22ad).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
src/caustics/lenses/point.py 94.44% 2 Missing ⚠️
src/caustics/lenses/sie.py 94.28% 2 Missing ⚠️
src/caustics/lenses/external_shear.py 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #304      +/-   ##
==========================================
+ Coverage   91.92%   92.16%   +0.23%     
==========================================
  Files          55       55              
  Lines        2279     2399     +120     
==========================================
+ Hits         2095     2211     +116     
- Misses        184      188       +4     
Flag Coverage Δ
unittests 92.16% <95.96%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ConnorStoneAstro ConnorStoneAstro changed the title New parametrizations for external shear and point mass feat: New parametrizations for external shear and point mass Dec 20, 2024
@ConnorStoneAstro ConnorStoneAstro linked an issue Dec 21, 2024 that may be closed by this pull request
@ConnorStoneAstro
Copy link
Member Author

Now also new parametrization for SIE

Copy link
Collaborator

@mjyb16 mjyb16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very slick! I will be testing this out in real life on real data quite soon, let's merge it and patch later if needed.

@ConnorStoneAstro ConnorStoneAstro merged commit 63df69f into dev Jan 25, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Features: Introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External shear angular parameterization
2 participants