Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic ssp dev #37

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
bdcd3b5
not sure at this point how to organize everything but just for the sa…
AlexaVillaume Aug 22, 2023
af1f5b1
fixing a small issue with getting data_path
AlexaVillaume Aug 24, 2023
b470e88
fixing a small issue with getting data_path
AlexaVillaume Aug 24, 2023
9a44b80
renaming to be more informative
AlexaVillaume Aug 24, 2023
42216fa
whoops...this is why the renaming necessary
AlexaVillaume Aug 24, 2023
adb101a
need some safeguards wrt coverage between the isochrones and the stel…
AlexaVillaume Aug 24, 2023
a7f889b
making progress on getting MLCRs, including fixing SSP synthesis
AlexaVillaume Sep 11, 2023
c264505
adding salpeter imf to help troubleshoot and to help figure out where…
AlexaVillaume Sep 11, 2023
70fd5db
getting salpeter imf working
AlexaVillaume Sep 11, 2023
47f52ad
adding to the normalization functionality in the abstract IMF class
AlexaVillaume Sep 13, 2023
f3d4d8d
adding unit test for imf normalization
AlexaVillaume Sep 14, 2023
36355a8
the wonders of unit tests
AlexaVillaume Sep 14, 2023
f15e04d
added class for abritary two slope powerlawe IMF
AlexaVillaume Sep 14, 2023
69880e3
mostly just refactoring the forward function to make it easier for me…
AlexaVillaume Sep 14, 2023
5e3adba
small changes
AlexaVillaume Sep 14, 2023
522c0ef
leaving this to fix mist isochrone issue
AlexaVillaume Nov 21, 2023
01ad142
Wondering if the error I'm getting with some of the isochrones, e.g.,…
AlexaVillaume Nov 21, 2023
37de906
should not be making selections based on anything other than age at t…
AlexaVillaume Nov 22, 2023
ea875dd
Now that I have a clearer understanding of nature of the problem -- s…
AlexaVillaume Nov 22, 2023
9ec205f
at the very least the selection by metalliicity is wrong in get_isoch…
AlexaVillaume Nov 22, 2023
9726b68
close but no cigar selecting on both metallicity AS WELL AS age...but…
AlexaVillaume Nov 22, 2023
5773c3d
the issues with the determining the metallicity and age indices does …
AlexaVillaume Nov 22, 2023
785e37a
There is indeed a serious bug in the construction of the isochrone gr…
AlexaVillaume Nov 22, 2023
5e43c31
making progress fixing the bugs, something still not right about the …
AlexaVillaume Nov 22, 2023
0afb706
several bug fixes involving indexing, data typing, and some float iss…
AlexaVillaume Nov 22, 2023
dbf0ecd
checking full ssp synthesis in light of the bug fixes I made to the i…
AlexaVillaume Nov 22, 2023
76367f2
introducing the use of a lighthouse environment variable in the hopes…
AlexaVillaume Nov 22, 2023
425825b
trying to find all instances where environment variable should be used
AlexaVillaume Nov 22, 2023
ed73aa9
trying to find all instances where environment variable should be used
AlexaVillaume Nov 22, 2023
fbc3104
added unit test for enviornment variable
AlexaVillaume Nov 22, 2023
a3ae6f0
using environment variable
AlexaVillaume Nov 22, 2023
f87806b
misplaced forward slash
AlexaVillaume Nov 22, 2023
36e0990
think this is the last of directory_path variales that need to be rep…
AlexaVillaume Nov 22, 2023
c7506d1
fixed all the path stuff st I can delete the notebooks from this repo…
AlexaVillaume Nov 22, 2023
308d6e7
Merge branch 'main' into isochrone_dev
AlexaVillaume Nov 22, 2023
b48ef9f
cleaned up the function a bit
AlexaVillaume Nov 24, 2023
9fc441a
the normalization constant is a property of the form of the IMF alone
AlexaVillaume Nov 24, 2023
5dd697d
refactoring the Basic_SSP class to help make the whole development pr…
AlexaVillaume Nov 25, 2023
cca0633
refactoring Basic_SSP class in light of issues that came up while deb…
AlexaVillaume Nov 25, 2023
e34d809
found the reason for the discrepancy in the spectral unitsgit status …
AlexaVillaume Dec 4, 2023
d3a6be2
adding phase selection back in
AlexaVillaume Dec 7, 2023
d7eac3f
finally getting around to fixing the retrieval of the stellar atmosph…
AlexaVillaume Dec 7, 2023
8c4df1b
small fixes to convert variables to torch datatypes
AlexaVillaume Dec 7, 2023
2d92203
added lower and upper mass limits in get_isochrone
AlexaVillaume Dec 7, 2023
424651f
isochrone retrieval bug fixes
AlexaVillaume Dec 8, 2023
d35bb7e
changes to go with verify_ssps notebook
AlexaVillaume Dec 8, 2023
2da5cea
finally found the source of the normalization bug
AlexaVillaume Dec 8, 2023
3d54339
pushing everything else because now the Kroupa and Salpeter SSPs in L…
AlexaVillaume Dec 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
leaving this to fix mist isochrone issue
AlexaVillaume committed Nov 21, 2023
commit 522c0efe8585a6c02e5e08d4a2eb8a5e64d766b6
181 changes: 150 additions & 31 deletions MLCRs_sandbox.ipynb

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lighthouse/SSP/basic_ssp.py
Original file line number Diff line number Diff line change
@@ -143,7 +143,7 @@ def forward(self, metalicity, Tage, alpha) -> torch.Tensor:


# SSP in L_sun Hz^-1, CvD models in L_sun micron^-1, convert
spectrum *= utils.light_speed/self.sas.wavelength**2
# spectrum *= utils.light_speed/self.sas.wavelength**2

return spectrum