Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @types/node from 10.17.60 to 22.10.9 #209

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 23, 2025

Bumps @types/node from 10.17.60 to 22.10.9.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 10.17.60 to 22.10.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 23, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 24, 2025

Superseded by #210.

@dependabot dependabot bot closed this Jan 24, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/types/node-22.10.9 branch January 24, 2025 12:05
@ChuckJonas
Copy link
Owner

@adangel thoughts on disabling dependabot? Seems noisy and a probably mostly solved by just running npm audit fix every time we release.

@adangel
Copy link
Collaborator

adangel commented Jan 24, 2025

I would keep it running. The main problem is, that nobody (including me) reacts on these PRs - and the CI build is failing with these. The longer they lay around, the old they get and accumulate more problems. I doubt that a simple "npm audit fix" will always work. IMHO, it's better if we keep the dependencies up to date instead of doing a big bang upgrade while releasing and potentially break something.

If the upgrades work without problem, you can see it in the github actions result and merging is a simple click. But all the PRs were failing, so I stopped merging them.

I'm currently working through the list of PRs and try to fix them (e.g. webpack couldn' be updated, because we still using typescript 3 (!)...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants