Fix #181: Call PMD via java directly, don't use pmd.bat anymore #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works under Linux...
The quotes are not needed (anymore?) Also it is enough to have only jrePath on PATH
adangel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The culprit is the '&' character in the workspace path...
If not within quotes, this is interpreted as conditional operator -> https://ss64.com/nt/syntax-conditional.html
This PR changes now how we call PMD: we don't use pmd.bat anymore, so we don't need to think about when to quote, what to quote or escape (cmdline behave different then batch file execution in terms of quoting...).
This also enables us to use a PMD distribution without pmd.bat, see #177 .
This additionally fixes a problem with the jrePath - I think, this didn't work for a while. Now we have also a test for that configuration option.