Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced array_merge with array spread operator. #20

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

markdorison
Copy link
Contributor

@markdorison markdorison commented Nov 2, 2023

Description

Replaced array_merge with array spread operator.

Motivation / Context

Ensure rector is passing. First surfaced in #19.

Testing Instructions / How This Has Been Tested

Tests should pass.

Additional Info

https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#arrayspreadinsteadofarraymergerector

@markdorison markdorison self-assigned this Nov 2, 2023
@ghost
Copy link

ghost commented Nov 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@adamzimmermann adamzimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned something new today. 🎉

This helped me understand/confirm the change.

src/Http/Client.php Show resolved Hide resolved
@markdorison markdorison merged commit 660879a into 1.x Nov 3, 2023
4 checks passed
@markdorison markdorison deleted the rector-array-spread branch November 3, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants