Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two New Error/Security Logging Service Issue Templates and Update Checklists for Others #38

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

danarbello
Copy link
Member

@danarbello danarbello commented Mar 27, 2024

Description

Now that we are starting to actively log more Sentry and StackHawk reports within our various projects, this PR proposes the addition of issues templates for them.

While I am at it, this PR also replaces the classic acceptance criteria checklists (- [ ]) with the new, dynamic Tasklists feature (still in beta but works swimmingly in my experience so far). This bubbles up information to different views with Projects making it easier to see the progress of a given task. Additionally, Tasklists items can be converted into child issues with little effort.

Communicates progress at view level Ease of subissue creation and tracking progress at issue level Quick issue config
Screenshot 2024-03-28 at 9 40 30 AM Screenshot 2024-03-28 at 9 40 44 AM Screenshot 2024-03-28 at 9 44 24 AM

Motivation / Context

Imprivata's security project is in dire need of templates for these two services.

Mind, these are not perfect. We might find a need to update these as we log more over time but for now they'll make do.

Testing Instructions / How This Has Been Tested

Read and approve or disapprove with a requested change.

@danarbello danarbello added the enhancement New feature or request label Mar 27, 2024
@danarbello danarbello self-assigned this Mar 27, 2024
@danarbello
Copy link
Member Author

Whoever is reviewing this, what would you think about changing the "Acceptance Criteria" to a Tasklist instead? I've been removing them manually every time I triage an issue because on the Tasklist will dynamically track subtasks within an issue (just plopping checklists under a seciton in the description does not).

Copy link
Member

@mmatsoo mmatsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Happy to try the task list approach!

@danarbello
Copy link
Member Author

Thank you, @mmatsoo. My latest commit replaces classic AC checklists with Tasklists for the other applicable templates, as well.

I'm requesting more folks for review because of this.

@danarbello danarbello changed the title Add Two New Error/Security Logging Service Issue Templates Add Two New Error/Security Logging Service Issue Templates and Update Checklists for Others Mar 28, 2024
Copy link

@michelegrace michelegrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danarbello danarbello merged commit d54dd28 into main Mar 28, 2024
2 checks passed
@danarbello danarbello deleted the add-new-stackhawk-issue-template branch March 28, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants