Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair many ref error: path issue. #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eaglexmw-gmail
Copy link

fix bug: import module from invalid path.
all compile/test ok.

@ChristopherChudzicki
Copy link
Owner

Hi @eaglexmw-gmail Thanks for opening a PR.

Those imports are not broken since math3d uses NODE_PATH=src/, the src directory is searched for modules before node_modules.

Admittedly, this is not really a great way to implement absolute imports... I think for the rewrite of math3d (in the works) I'll use something like craco to patch create react app to have @/blah as absolute import of blah.

NODE_PATH=src

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants