Use std::call_once for code that only runs once

ChrisThrasher · Dec 16, 2023 · e8d567c · e8d567c
1 parent 79df699
commit e8d567c
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/src/SFML/Audio/SoundFileFactory.cpp b/src/SFML/Audio/SoundFileFactory.cpp
@@ -39,6 +39,7 @@
 #include <SFML/System/MemoryInputStream.hpp>
 #include <SFML/System/Utils.hpp>
 
+#include <mutex>
 #include <ostream>
 
 
@@ -47,18 +48,18 @@ namespace
 // Register all the built-in readers and writers if not already done
 void ensureDefaultReadersWritersRegistered()
 {
-    static bool registered = false;
-    if (!registered)
-    {
-        sf::SoundFileFactory::registerReader<sf::priv::SoundFileReaderFlac>();
-        sf::SoundFileFactory::registerWriter<sf::priv::SoundFileWriterFlac>();
-        sf::SoundFileFactory::registerReader<sf::priv::SoundFileReaderMp3>();
-        sf::SoundFileFactory::registerReader<sf::priv::SoundFileReaderOgg>();
-        sf::SoundFileFactory::registerWriter<sf::priv::SoundFileWriterOgg>();
-        sf::SoundFileFactory::registerReader<sf::priv::SoundFileReaderWav>();
-        sf::SoundFileFactory::registerWriter<sf::priv::SoundFileWriterWav>();
-        registered = true;
-    }
+    static std::once_flag flag;
+    std::call_once(flag,
+                   []()
+                   {
+                       sf::SoundFileFactory::registerReader<sf::priv::SoundFileReaderFlac>();
+                       sf::SoundFileFactory::registerWriter<sf::priv::SoundFileWriterFlac>();
+                       sf::SoundFileFactory::registerReader<sf::priv::SoundFileReaderMp3>();
+                       sf::SoundFileFactory::registerReader<sf::priv::SoundFileReaderOgg>();
+                       sf::SoundFileFactory::registerWriter<sf::priv::SoundFileWriterOgg>();
+                       sf::SoundFileFactory::registerReader<sf::priv::SoundFileReaderWav>();
+                       sf::SoundFileFactory::registerWriter<sf::priv::SoundFileWriterWav>();
+                   });
 }
 } // namespace