Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force param #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kuzmany
Copy link
Contributor

@kuzmany kuzmany commented Jun 4, 2021

This just add force param to

{feeditems count="30" force="1"}

This force display items in order in RSS (by default use date)

@ChrisRAoW
Copy link
Owner

@kuzmany Thanks for your PR. Personally I think "force" a bit misleading / vague. I think an attribute "order" is better with the the options:

  • rss
  • date

What do you think?

@kuzmany
Copy link
Contributor Author

kuzmany commented Jan 3, 2022

@ChrisRAoW I understand you, but we already use it in production, then It make BC for use. I think it's great improvement and bugfix for some users. It's up to you decide to close it or merge it.

@ChrisRAoW
Copy link
Owner

@kuzmany What do you mean with "BC for use"?

@ChrisRAoW
Copy link
Owner

ChrisRAoW commented Jan 3, 2022

@kuzmany Ah "backwards compatible"....I understand. Will give it another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants