Skip to content

Commit

Permalink
📝 Update todo comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ChmielewskiKamil committed Sep 1, 2024
1 parent 9bd7dd7 commit 39f3b56
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 0 additions & 1 deletion ast/ast.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ type FunctionType struct {

// Param is not a type and not an expression, but we place it here since it is
// closely related to types.
// @TODO: Data location is missing
type Param struct {
Name *Identifier // param name e.g. "x" or "recipient"
Type Type // e.g. ElementaryType, FunctionType etc.
Expand Down
4 changes: 4 additions & 0 deletions parser/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ func (p *Parser) parseFunctionDeclaration() *ast.FunctionDeclaration {
// ( typeName <<data location>> <<identifier>>, ... )
// The typeName is required while data location and identifier are optional.

// @TODO: Param list parsing could be extracted to a separate
// function since it is used in other places as well e.g. fallback,
// receive functions, modifiers and return values.

// @TODO: Params can have other types than elementary types. For example:
// - user defined like Contract names and structs
// - function types
Expand Down

0 comments on commit 39f3b56

Please sign in to comment.