Fix ignore RenderType when generating Faces and baking Model #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and its private `generateFaces()` method. Using `IBlockNeighborhood` when accessing `IBlockInformation` in `GreedyMeshBuilder.MaterialProvider` outside the current block. Adding method `isSeeThrough()` to `IBlockInformation` Adding `ChiselRenderType` as an argument to `GreedyMeshBuilder`'s `buildMesh()` method. Replacing `GreedyMeshBuilder` with an extended binary greedy mesh builder.
marchermans
requested changes
Nov 10, 2024
Comment on lines
+49
to
+52
| final boolean RENDERTYPE_SOLID = chiselRenderType.layer.equals(RenderType.solid()); | ||
| final int BITS_PER_BLOCK_SIDE = StateEntrySize.current().getBitsPerBlockSide(); | ||
| final int BITS_PER_BLOCK_SIDE_P = BITS_PER_BLOCK_SIDE + 2; | ||
| final int BITS_PER_BLOCK_SIDE_P2 = BITS_PER_BLOCK_SIDE_P * BITS_PER_BLOCK_SIDE_P; |
There was a problem hiding this comment.
Please use the code formatting that aligns with the rest.
In this particular case UPPER_CASE_SNAKE is ment for static final fields.
/me needs to add a formatting file, and gradle step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #1262
Changes:
Adding
IBlockNeighborhoodtoChiseledBlockBakedModel's Constructor and its privategenerateFaces()method.Using
IBlockNeighborhoodwhen accessingIBlockInformationinGreedyMeshBuilder.MaterialProvideroutside the current block.Adding method
isSeeThrough()toIBlockInformationAdding
ChiselRenderTypeas an argument toGreedyMeshBuilder'sbuildMesh()method.Replacing
GreedyMeshBuilderwith an extended binary greedy mesh builder.