Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pastaq/new frzr #118

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

Pastaq/new frzr #118

wants to merge 55 commits into from

Conversation

pastaq
Copy link
Contributor

@pastaq pastaq commented Aug 25, 2024

All the new quirks patterns, merge conflicts removed, and updated to latest.

NeroReflex and others added 30 commits May 18, 2024 19:09
In bash test [] requires specifing spacing
Pre-refactor frzr has an hardcoded call to this file.

The refactored frzr handles device-quirks using migrations and frzr-tweaks utility.

To avoid failures installing a new deployment move the id-device to another file and replace it with a never-failing stub.
Re-enabled Root user check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes device quirks chimeraos dependent, do we want that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus is to make it NOT chimeraos dependent.... Why do you say so? In theory it should now support both mkinitcpio and dracut....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well why is there frzr stuff in here in the first place? Secondly it assumes certain configurations of either dracut (with a assumed configuration) or mkinitcpio being there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well why is there frzr stuff in here in the first place? Secondly it assumes certain configurations of either dracut (with a assumed configuration) or mkinitcpio being there.

Have you read frzr-initramfs? It's an echo "deprecated" to avoid failure while installing new images with old frzr.

Also, what configuration is it assuming? Probably the existence of a script? That dracut-install.sh is described in the archwiki

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that is fine and all. That dracut-install.sh already assumes no UKI for example, that's what I mean with assuming configurations.

Same for the depr warning and all, which is fine, but IMO this is part of frzr NOT device-quirks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that is fine and all. That dracut-install.sh already assumes no UKI for example, that's what I mean with assuming configurations.

Same for the depr warning and all, which is fine, but IMO this is part of frzr NOT device-quirks.

My dracut-install.sh does create uki just fine. The only problem I would have woth installing this package would be that after initramfs regeneration secure boot signing would not be applied, but it would be on normal kernel updated via pacman

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing my point. This needs to be part of the FRZR package not device-quirks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that anything frzr specific needs to be in frzr.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this called frzr-tweaks? It's just saving the conf file with env's.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also incomplete, controller wake settings are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants