Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue_609 #648

Closed
wants to merge 1 commit into from
Closed

issue_609 #648

wants to merge 1 commit into from

Conversation

jj105
Copy link
Contributor

@jj105 jj105 commented Feb 21, 2020

No description provided.

@jj105
Copy link
Contributor Author

jj105 commented Feb 21, 2020

Hi, Jon.
I edited code to fix issue_609.
but on my environment, it takes too long time (more than an hour) to create a new applet.
I think it loads too many resources.

@jj105 jj105 requested a review from shnizzedy February 21, 2020 12:24
@jj105
Copy link
Contributor Author

jj105 commented Feb 21, 2020

Can you please tell me what should I do to make process of creating a new applet run faster?

@shnizzedy
Copy link
Member

Can you please tell me what should I do to make process of creating a new applet run faster?

It's an open epic and in my opinion, the current weakest link in the whole project. On my machine, it takes ~1‒2 seconds per JSON-LD document to load a protocol, so for testing I just choose smallish protocols, like reproschema:protocols/mindlogger-demo/mindlogger-demo_schema, which still takes several minutes.

See also #625 (comment)

Copy link
Member

@shnizzedy shnizzedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR resolves #609!

working screen grab

@jj105 ― This PR is based on 66c752c which predates #637 which resolved an environment issue causing integration tests to fail. If you merge recent changes into your branch (f64fe00c978e48606a26ecd18fa01bb3150c419e) or rebase your changes onto a more recent commit (539830c643c3a4fbcbc29ff984fbc9382de526fa), your code passes the CI tests.

The changelog would also need to be updated prior to merging.

@binarybottle @WorldImpex @henryrossiter @hotavocado @devbtech ― I leave it to y'all if you like this applet naming strategy or if you want to make changes, but the bones are in place in this PR:

names

Bonejangles

@shnizzedy
Copy link
Member

We only have ~28% coverage of the Python core in this codebase as of a8ba865, but I'd argue that's no reason not to include tests with new functionality.

Write a test

The output of GET /user/applets?role=coordinator&unexpanded=true will be an Array of Objects in which applet["http://www.w3.org/2004/02/skos/core#prefLabel"]["@value"] will be the display name of an applet.

GET /user/applets?role=coordinator&unexpanded=true

#645 (comment)

@shnizzedy shnizzedy mentioned this pull request Feb 21, 2020
@jj105 jj105 closed this Feb 21, 2020
@jj105 jj105 deleted the Ihor-Test-Second branch February 21, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants