DataDog support for Worker and Scheduler #1712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
➡️ Preview environment created: Click Me! |
|
❌ E2E tests failed |
sultanofcardio
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
@aweiland I have a few cosmetic suggestions, but I tested and it looks like this works 👍
| logger.setLevel(logging.INFO) | ||
| logger.addHandler(logging.StreamHandler()) | ||
| logger.info("Enabling Datadog") | ||
| # import ddtrace.auto # noqa |
There was a problem hiding this comment.
Suggested change
| # import ddtrace.auto # noqa |
| # network={"client": {"ip": real_host, "port": client_port}}, | ||
| # duration=process_time, | ||
| # ) | ||
| # response.headers["X-Process-Time"] = str(process_time / 10 ** 9) |
There was a problem hiding this comment.
Should we be putting this back in?
Suggested change
| # response.headers["X-Process-Time"] = str(process_time / 10 ** 9) | |
| response.headers["X-Process-Time"] = str(process_time / 10 ** 9) |
There was a problem hiding this comment.
I debated whether it's worth sending back to the client or not. We have this information in Datadog so it didn't seem useful to me.
There was a problem hiding this comment.
In that case, we can remove the comment
Co-authored-by: Kenroy Gobourne <[email protected]>
Co-authored-by: Kenroy Gobourne <[email protected]>
Co-authored-by: Kenroy Gobourne <[email protected]>
Co-authored-by: Kenroy Gobourne <[email protected]>
…logger-backend-refactor into broker-structlog
sultanofcardio
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-8041
Changes include:
🪤 Peer Testing
✏️ Notes