chore: Bump aws-actions/amazon-ecs-deploy-task-definition from v1 to v2 #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sultanofcardio
commented
Jan 9, 2025
|
➡️ Preview environment failed to be destroyed |
|
❌ E2E tests failed |
aweiland
approved these changes
Jan 9, 2025
sultanofcardio
deleted the
chore/bump-amazon-ecs-deploy-task-definition-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is a quick PR to fix the recent deployment failures to dev. It bumps
aws-actions/amazon-ecs-deploy-task-definitionfrom v1 to v2.I did a quick search and there doesn’t appear to have been any recent changes to either the task definition in ECS or the workflow file run_deploy_dev.yaml in GitHub.
I found this GitHub issue that also doesn’t hint at a cause, but the consensus is that upgrading
aws-actions/amazon-ecs-deploy-task-definitionfrom v1 to v2 fixes the issue.🪤 Peer Testing
We can possibly test this by uncommenting this line, provided all the secrets and variables will be available on this branch
mindlogger-backend-refactor/.github/workflows/run_build_deploy.yaml
Line 7 in 9cd8ad1
✏️ Notes
N/A