-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add database errors handlers to get better error messages (M2-8184) #1700
feat: Add database errors handlers to get better error messages (M2-8184) #1700
Conversation
70f0512
to
b2d815b
Compare
➡️ Preview environment failed to be destroyed |
❌ E2E tests failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one Pylance comment so far, code looks fine otherwise.
I'm struggling to figure out how to test this. I've tried misconfiguring the report server for an applet, but still not sure how to trigger the error. @rcmerlo would you mind filling out the 🪤 Peer Testing
section from the PR description template? I know it's a little more work for you to do that, but it will help save the rest of us time during review. Thanks!
Also, the AC states:
But your PR description states:
Which one is correct? |
Co-authored-by: Farmer Paul <[email protected]>
@farmerpaul I remember we commented on planning for this ticket that we should keep API returning 500 to not break FE behavior, since users can't handle this kind of error, we should only report it in logs to help support team to fix it. |
📝 Description
Add new error handlers for database error to have better error messages in logs, this will help to fix any error related to arbitrary servers. It will keep returning http 500 status error
🔗 Jira Ticket M2-8184
🪤 Peer Testing
Prepare environment:
python src/cli.py arbitrary add --db-uri postgresql+asyncpg://postgres:[email protected]/dev --storage-type aws --storage-secret-key fake --storage-access-key fake --storage-region us-east-1 --storage-bucket arbitrary OWNER_EMAIL --force
alembic -c alembic_arbitrary.ini upgrade head
python src/cli.py arbitrary show
To test connection refused error:
To test wrong password error:
✏️ Notes
To remove abritrary server, just call:
python src/cli.py arbitrary remove OWNER_EMAIL