bugfix(summary-flows) targetSubjectId is required in query filters. (M2-6900)

src/apps/answers/crud/answers.py

@@ -27,7 +27,7 @@
     UserAnswerItemData,
 )
 from apps.answers.errors import AnswerNotFoundError
-from apps.answers.filters import AppletSubmitDateFilter, ReviewAppletItemFilter
+from apps.answers.filters import AppletSubmitDateFilter
 from apps.applets.db.schemas import AppletHistorySchema
 from apps.applets.domain.applet_history import Version
 from apps.shared.filtering import Comparisons, FilterField, Filtering
@@ -222,19 +222,6 @@ async def get_flow_submissions(
 
         return parse_obj_as(list[FlowSubmission], data), count
 
-    async def get_respondents_answered_activities_by_applet_id(
-        self, applet_id: uuid.UUID, filters: ReviewAppletItemFilter
-    ) -> list[AnswerSchema]:
-        query: Query = select(AnswerSchema)
-        query = query.where(AnswerSchema.applet_id == applet_id)
-        query = query.where(func.date(AnswerSchema.created_at) == filters.created_date)
-        if filters.target_subject_id:
-            query = query.where(AnswerSchema.target_subject_id == filters.target_subject_id)
-        query = query.order_by(AnswerSchema.created_at.asc())
-
-        db_result = await self._execute(query)
-        return db_result.scalars().all()
-
     async def get_respondents_submit_dates(
         self, applet_id: uuid.UUID, filters: AppletSubmitDateFilter
     ) -> list[datetime.date]:

src/apps/answers/filters.py

@@ -14,7 +14,7 @@ class SummaryActivityFilter(BaseQueryParams):
 
 
 class ReviewAppletItemFilter(BaseQueryParams):
-    target_subject_id: uuid.UUID | None
+    target_subject_id: uuid.UUID
     created_date: datetime.date
 
 

src/apps/answers/tests/test_answers.py

@@ -1888,3 +1888,20 @@ async def test_access_to_activity_list(
         client.login(user)
         response = await client.get(url)
         assert response.status_code == expected
+
+    async def test_review_flows_one_answer_without_target_subject_id(
+        self, mock_kiq_report, client, tom: User, applet_with_flow: AppletFull, tom_answer_activity_flow, session
+    ):
+        client.login(tom)
+        url = self.review_flows_url.format(applet_id=applet_with_flow.id)
+
+        response = await client.get(
+            url,
+            dict(
+                createdDate=datetime.datetime.utcnow().date(),
+            ),
+        )
+        assert response.status_code == 422
+        data = response.json()
+        assert data["result"][0]["message"] == "field required"
+        assert data["result"][0]["path"] == ["query", "targetSubjectId"]