Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow-submission): Fix flow submission endpoints filtering out incomplete submissions(M2-6616) #1378

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

vshvechko
Copy link
Contributor

  • Tests for the changes have been added

📝 Description

🔗 Jira Ticket M2-6616

Changes include:

  • Filter out incomplete submissions for GET /answers/applet/{applet_id}/review/flows
  • Filter out incomplete submissions for GET /answers/applet/{applet_id}/flows/{flow_id}/identifiers
  • Add isCompleted flag to the submission data for
    GET /answers/applet/{applet_id}/flows/{flow_id}/submissions/{submit_id}
  • Add tests for the incomplete submission case for GET /answers/applet/{applet_id}/flows/{flow_id}/submissions

@vshvechko vshvechko merged commit cb18e2e into feature/summary-submissions-support Jun 5, 2024
33 checks passed
@vshvechko vshvechko deleted the bugfix/M2-6616 branch June 5, 2024 09:27
iwankrshkin added a commit that referenced this pull request Jun 26, 2024
* feature: flow assessments  and notes (M2-6584, M2-6585) (#1304)

* fix: Perform the Reviewers Assessment for Activity Flow

Allow to perform the Reviewers Assessment for the entire Activity Flow

* fix: Add unittests for flow's assessments

* fix: Add appletMeta to applet retrieve

appletMeta.hasAssessment attribute added to determine the existence of an assessment in an applet

* fix: Add notes to submission

New feature allows add notes for entire flow by submission id

* fix: Add submission id in data export

Added reviewedSubmissionId to data export

* fix: Fix comments

* fix: Changed field name in export

* fix: Add index

* fix: Fix assessment retrieve

* fix: Fix assessment retrieve rights

* fix: Submission rights check

* fix: Add submission reviews list

* fix: Note rights error

* fix: Method name

* wip: Split assessments list and retrieve for activity and flow methods (M2-6584)

* wip[flow assessments]:  fixes after merge (M2-6584)

* wip[flow assessments]:  fix reviewed_flow_submit_id

* wip[flow assessments]:  fix reviews for flow

* wip[flow assessments]:  remove case from query

* wip[flow assessments]:  fix comments

* feature(flow's latest report): Latest report (combined) support for flows (#1372)

* fix(flow-submission): Fix flow submission endpoints filtering out incomplete submissions(M2-6616) (#1378)

* fix(notes): Add user.id to note list (#1406)

* fix(responses): Fix for emptyIdentifiers filter (#1418)

* fix(summary): Fix getting versions, identifiers, submissions for deleted flows (m2-7030) (#1453)

* fix(summary): Fix getting versions, identifiers, submissions for fdeleted flows

* (wip): Using id instead id_version for join

---------

Co-authored-by: vshvechko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants