Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2-5200: Update admin panel password reset page link #1113

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

sultanofcardio
Copy link
Contributor

@sultanofcardio sultanofcardio commented Feb 21, 2024

📝 Description

🔗 Jira Ticket M2-5200

Note

This PR is a follow-up to #1100

This PR primarily updates the admin panel link in the email generated by the password recovery route.The path of that link is currently set to /password-recovery, but based on the conventions of the admin panel it should be /auth/password-recovery.

I also removed references to Girder from the email subject to satisfy M2-5270

🪤 Peer Testing

To test this change, modify your .env file with the following values

SERVICE__URLS__FRONTEND__WEB_BASE="https://localhost:5173"
SERVICE__URLS__FRONTEND__ADMIN_BASE="https://localhost:3000"
  1. Start up the API server and the admin web app.
  2. Navigate to the forgot password page in the admin web app
  3. Enter your email address and send the request
  4. Open the local mailhog and check the link in the email
    Expected outcome: The subject line should say "MindLogger Admin" and the link should be in the format https://localhost:3000/auth/password-recovery?key=a5263fd7-9eb3-305c-868c-2e172ab4cad5&[email protected] (notably the path starts with /auth)

@sultanofcardio sultanofcardio self-assigned this Feb 21, 2024
@sultanofcardio sultanofcardio marked this pull request as ready for review February 21, 2024 14:00
@sultanofcardio sultanofcardio merged commit 65636b7 into develop Feb 21, 2024
3 checks passed
@sultanofcardio sultanofcardio deleted the feature/M2-5200-reset-password-email-link branch February 21, 2024 15:34
iwankrshkin added a commit that referenced this pull request Feb 29, 2024
* Update invitation email copy

Update footer design and content

Update header logo

* Update email assets URL to use new bucket

* M2-5200: Update admin panel password reset page link (#1113)

As a follow-up to [#1100](#1100), this PR primarily updates the admin panel link in the email generated by the password recovery route. The path of that link is currently set to `/password-recovery`, but based on the conventions of the admin panel it should be `/auth/password-recovery`.

I also removed references to Girder from the email subject to satisfy [M2-5270](https://mindlogger.atlassian.net/browse/M2-5270)

* M2-5315: Add conversion support (#1115)

* Add conversion support.
* Add use_arbitrary check to the get_arbitrary_info.

* Add alternate text for mindlogger logo

Co-authored-by: Farmer Paul <[email protected]>

* Add french alternate text to Apple Store logo

Co-authored-by: Farmer Paul <[email protected]>

* Add french alternate text to Google Play store logo

Co-authored-by: Farmer Paul <[email protected]>

* Update README file organizing sections and contents

* Add font to header template

* Fix tests

---------

Co-authored-by: Cleber Santos <[email protected]>
Co-authored-by: Kenroy Gobourne <[email protected]>
Co-authored-by: Ilya Bogretsov <[email protected]>
Co-authored-by: Marty <[email protected]>
Co-authored-by: Farmer Paul <[email protected]>
Co-authored-by: Rodrigo Merlo <[email protected]>
Co-authored-by: Carlos Chacon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants