Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with invalidation of applet base info query data (M2-8151) #885

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

qiushihe
Copy link
Contributor

📝 Description

🔗 Jira Ticket M2-8151

This PR fixes an issue introduced in #873 where the "base info" query data cache is not invalidated, leading to the app crashing after an activity/flow is added to an existing applet.

📸 Screenshots

N/A

🪤 Peer Testing

  1. Create an applet
  2. Create an activity
  3. Log into the mobile app
  4. Go into the activity listing screen
  5. Create another activity
  6. In the mobile app, go back to the applet listing screen and refresh
  7. Go into the activity listing screen

At this point, the app should not crash.

✏️ Notes

N/A

Copy link
Contributor

@mbanting mbanting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @qiushihe and confirmed crash is no longer happening. Thank you

src/shared/api/services/appletsService.ts Show resolved Hide resolved
src/shared/api/services/appletsService.ts Show resolved Hide resolved
@mbanting mbanting merged commit b2e85f3 into dev Nov 4, 2024
5 checks passed
@farmerpaul farmerpaul deleted the fix/m2-8151-new-activity-crash branch December 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants