Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unity itemtype (M2-7632) #879

Merged

Conversation

ChaconC
Copy link
Contributor

@ChaconC ChaconC commented Oct 28, 2024

📝 Description

Adds support for parsing Unity ItemType into an activity.

🔗 Jira Ticket M2-7632

📸 Screenshots

Before (Optional) After

🪤 Peer Testing

  • Create an applet containing a Unity Item
  • Open app
  • Unity Item should be visible
  • Navigate to the Unity Item

✏️ Notes

This is considered a WIP, most of the required work should be handled prior to merging the feature branch. For now this is meant to aide development of the Unity app side.

@ChaconC ChaconC changed the title Feat/m2 7632 unity itemtype feat: unity itemtype (M2-7632) Oct 28, 2024
@ChaconC ChaconC marked this pull request as ready for review October 28, 2024 14:49
@ChaconC ChaconC requested a review from felipeMetaLab October 28, 2024 14:49
@ChaconC ChaconC force-pushed the feat/M2-7632-unity-itemtype branch from 7c1899e to eb294a0 Compare October 28, 2024 14:52
@felipeMetaLab
Copy link
Contributor

felipeMetaLab commented Oct 28, 2024

I reviewed just the code and it looks good, now I will test the functionality.

@felipeMetaLab
Copy link
Contributor

Hey @ChaconC is there any unity file you could share with me for create unity Item ?

@ChaconC ChaconC merged commit 8d66b5e into feature/M2-7439-merit-integration Oct 29, 2024
4 checks passed
@ChaconC ChaconC deleted the feat/M2-7632-unity-itemtype branch October 29, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants