-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M2-5381: Add initial set of linting rules for mobile repository #632
Conversation
586321f
to
d64329f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a scan the the rules and it's a good starting set that focuses on detecting potential bugs, performance issues, stale code, and security vulnerabilities. It looks like some of the more subjective or stylistic rules from the previous PR were removed as intended.
As mentioned in another PR and as you stated in the PR description, there will be conflicts with the rn-update-0.73.4
branch although I had a look and it should be relatively straightforward to resolve (at least the .eslintrc.js
file).
@BamMironov suggested waiting for that to be merged to dev
first before any further linting changes like this. Let's hold off merging this (but still aim to have it in before sprint end) until we have a better idea of where that's at. Alternatively you can already resolve the potential conflicts with that branch here.
By waiting we also give @BamMironov a chance to have a look at this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
But yes, let's hold it off till the RN update is merged.
d64329f
to
f672316
Compare
The changes from rn-update-0.73.4 have been merged into dev, so I rebased and resolved merge conflicts. I'll defer merging this until EOD Monday to give folks a chance to re-review |
📝 Description
🔗 Jira Ticket M2-5381
Note
This is a follow-up to #617
This PR creates an initial set of linting rules with a focus on enhancing code quality and maintainability without imposing strict stylistic guidelines. Each added rule should fall in one of the following categories:
This PR isn't meant to be exhaustive, and so there may be rules I have overlooked that could be added now (or later on as the need arises).
✏️ Notes
Please be generous, but focused with your feedback. I'm especially interested in feedback of this nature:
P.S. I'm mindful that this PR is potentially blocked by the work being done on the rn-update-0.73.4 branch. Please let me know if there are additional considerations I should make with that update in mind.