fix: fixing date parse when there is error in date conditions M2-8275 #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeMetaLab
changed the title
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ChaconC
reviewed
Nov 28, 2024
src/modules/Builder/components/ConditionRow/Condition/SwitchCondition/SwitchCondition.tsx
Outdated
Show resolved
Hide resolved
src/modules/Builder/components/ConditionRow/Condition/SwitchCondition/SwitchCondition.tsx
Outdated
Show resolved
Hide resolved
ChaconC
previously approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-8275
this PR was created to fix date parse when there is error in date conditions.
📸 Screenshots
Error (dev branch):
https://github.com/user-attachments/assets/4ab6ed60-6486-4b9e-bffc-00d3fa4204f7
https://github.com/user-attachments/assets/0d64e085-4024-4e36-aa08-0a727f1376d4
Solved:
https://github.com/user-attachments/assets/37882507-e5d6-461b-8e8a-4aba62f1e3fd
https://github.com/user-attachments/assets/1bbb4358-ea11-4cc1-a19a-036edce3c3e7
🪤 Peer Testing
1 - launch the admin app.
2 - create or edit an activity into an applet
3 - create a date item
4 - and create conditional logic
5 - set the date and save then click in activity ( check if it will retrieve error or not)
✏️ Notes
for more information, check the the ticket, it contain a video with error or check the video I left on PR, the first 2 videos is retrieving error.