Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor cleanups and fix test-block-generators command line parsing #868

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 13, 2025

the tool test-block-generators was failing on startup because the implied short command line switch for hard_fork_height was -h, clashing with --help.

This also makes FILE a positional required argument.

And it removes some unnecessary constants in tests.

@arvidn arvidn marked this pull request as ready for review January 13, 2025 12:58
@arvidn arvidn requested a review from AmineKhaldi January 13, 2025 12:58
Copy link

Pull Request Test Coverage Report for Build 12747468412

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.418%

Totals Coverage Status
Change from base Build 12747017402: 0.0%
Covered Lines: 13170
Relevant Lines: 15601

💛 - Coveralls

@arvidn arvidn merged commit f57de20 into main Jan 13, 2025
52 checks passed
@arvidn arvidn deleted the minor-cleanups branch January 13, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants