Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend SpendBundleConditions with the cost broken out #866

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 11, 2025

into execution_time and condition_time (as well as the existing total cost).

This is part of preparations for incrementally serialize compressed block generators. The cost we use for mempool items can't include the byte-cost, since it's only known as we're building the block. So this gives us access to the cost broken up into its components

Copy link

coveralls-official bot commented Jan 11, 2025

Pull Request Test Coverage Report for Build 12729632624

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.425%

Totals Coverage Status
Change from base Build 12699480254: 0.02%
Covered Lines: 13188
Relevant Lines: 15621

💛 - Coveralls

@arvidn arvidn force-pushed the execution-time branch 3 times, most recently from 3e8311d to f820eb0 Compare January 12, 2025 01:55
…time and condition_time (as well as the existing total cost)
@arvidn arvidn marked this pull request as ready for review January 12, 2025 18:09
@arvidn arvidn requested a review from matt-o-how January 13, 2025 09:03
@arvidn arvidn merged commit 10bc9f2 into main Jan 13, 2025
52 checks passed
@arvidn arvidn deleted the execution-time branch January 13, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants