Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax coin amount in fast-forward logic #344

Merged
merged 1 commit into from
Dec 15, 2023
Merged

relax coin amount in fast-forward logic #344

merged 1 commit into from
Dec 15, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 12, 2023

Update the fast-forward feature to allow the coin amount to change when "rebasing" a spend onto a later version of the same singleton.

@arvidn arvidn requested a review from AmineKhaldi December 12, 2023 16:45
@arvidn arvidn marked this pull request as ready for review December 12, 2023 16:51
Copy link

coveralls-official bot commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7226536921

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 86.061%

Totals Coverage Status
Change from base Build 7222544523: -0.02%
Covered Lines: 10854
Relevant Lines: 12612

💛 - Coveralls

@AmineKhaldi
Copy link
Contributor

I see two remaining tasks with this patch:

  1. We need to account for (and cover with tests) the fact that not only the latest version's amount can change, but its parent's amount can change too.
  2. We need to relax (and cover with tests) the check for output coins as it still requires the same amount.

@arvidn arvidn force-pushed the relax-ff-amount branch 4 times, most recently from 5f84dc4 to f8e3ab2 Compare December 14, 2023 22:23
@arvidn arvidn force-pushed the relax-ff-amount branch 6 times, most recently from 9e9adba to 681b337 Compare December 15, 2023 15:32
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arvidn arvidn merged commit 04dc70d into main Dec 15, 2023
53 checks passed
@arvidn arvidn deleted the relax-ff-amount branch December 15, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants