Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametrize datalayer proof of inclusion for rust as well #19281

Merged

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Feb 17, 2025

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests labels Feb 17, 2025
Copy link

coveralls-official bot commented Feb 17, 2025

Pull Request Test Coverage Report for Build 13395919088

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • 51 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.04%) to 91.454%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/util/merkle_blob.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 73.24%
chia/farmer/farmer.py 1 73.37%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/plotters/plotters.py 1 90.94%
chia/wallet/util/wallet_sync_utils.py 1 86.14%
chia/full_node/full_node.py 3 86.08%
chia/full_node/weight_proof.py 4 90.64%
chia/wallet/wallet_node.py 4 87.96%
chia/plotters/madmax.py 6 44.58%
Totals Coverage Status
Change from base Build 13335938018: -0.04%
Covered Lines: 105469
Relevant Lines: 115141

💛 - Coveralls

@altendky altendky marked this pull request as ready for review February 18, 2025 16:56
@altendky altendky requested a review from a team as a code owner February 18, 2025 16:56
Copy link
Contributor

File Coverage Missing Lines
chia/data_layer/util/merkle_blob.py 66.7% lines 62
Total Missing Coverage
6 lines Unknown 83%

@altendky altendky merged commit a8724f0 into long_lived/datalayer_merkle_blob Feb 18, 2025
299 of 300 checks passed
@altendky altendky deleted the rust_datalayer_proof_of_inclusion branch February 18, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants