Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-2108 Cover computing transactions filter for transaction blocks with only reward coins #19076

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

Extend test_request_block_headers_transactions_filter to cover the case when a transaction block only contains reward coins.

Current Behavior:

This test only covers transaction blocks with spends (and reward coins).

New Behavior:

This test covers also transaction blocks with only reward coins.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Dec 20, 2024
@AmineKhaldi AmineKhaldi self-assigned this Dec 20, 2024
Copy link

Pull Request Test Coverage Report for Build 12430410429

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.007%) to 91.518%

Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/full_node/full_node_api.py 1 84.67%
chia/farmer/farmer_api.py 2 94.38%
chia/timelord/timelord_launcher.py 2 90.71%
chia/server/node_discovery.py 3 81.28%
chia/full_node/full_node.py 7 86.27%
Totals Coverage Status
Change from base Build 12423040364: 0.007%
Covered Lines: 105246
Relevant Lines: 114819

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review December 20, 2024 15:01
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner December 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant