Reduce log spam with will not infuse block. #19069
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchirica
added
timelord
Fixed
almogdepaz
reviewed
Dec 23, 2024
| if found_index == -1: | ||
|
|
||
| found_index = self._get_rc_cache_index(block) | ||
| if found_index is None: |
There was a problem hiding this comment.
Suggested change
| if found_index is None: | |
| if self._get_rc_cache_index(block) is None: |
| @@ -337,6 +341,8 @@ async def _reset_chains(self, *, first_run: bool = False, only_eos: bool = False | |||
| self.iteration_to_proof_type[new_block_iters] = IterationType.INFUSION_POINT | |||
| # Remove all unfinished blocks that have already passed. | |||
| self.unfinished_blocks = new_unfinished_blocks | |||
| # Remove old overflow blocks that we didn't infuse. | |||
There was a problem hiding this comment.
we clean all the blocks we cant infuse in the loop above but we dont clean the blocks that we moved from self.overflow_blocks to the new_unfinished
i think just adding
if block in self.overflow_blocks:
self.overflow_blocks.remove(block)
to line 337 would be a better solution, also it looks like we currently duplicate blocks in both self.unfinished and self.overflow_blocks in the loop above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Current Behavior:
New Behavior:
Testing Notes: