mypy annotation for test_dos.py
#19036
Open
+36
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
Changed
AmineKhaldi
reviewed
Dec 12, 2024
| @@ -307,13 +315,13 @@ def is_closed(): | |||
| assert not ws_con.closed | |||
|
|
|||
| # Remove outbound rate limiter to test inbound limits | |||
| ws_con.outbound_rate_limiter = FakeRateLimiter() | |||
| ws_con.outbound_rate_limiter = FakeRateLimiter() # type: ignore[assignment] | |||
There was a problem hiding this comment.
Can we do without this type ignore?
There was a problem hiding this comment.
not without coming up with a different solution to make things unlimited
There was a problem hiding this comment.
Sent #19038 to address this.
There was a problem hiding this comment.
I'm not sure it's an improvement. it just hides the type-unsafety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Remove unused code and introduce stricter type checking of
test_dos.py, gradually getting closer to full mypy coverage.Current Behavior:
test_dos.pydoes not have full mypy coverage.There are 3 copies of an unused function,
get_block_path().New Behavior:
test_dos.pyhas full mypy coverage (the the extent our repo is configured).Unused function
get_block_path()has been removed.Testing Notes: