Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the vars for the test parameters too #18868

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

use the vars for the test parameters too #18868

wants to merge 2 commits into from
+11 −11

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 14, 2024 •
edited
Loading

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Nov 14, 2024
@aqk
Copy link
Contributor

aqk commented Nov 14, 2024

Looks good. Is this draft because you want to add more changes?

@altendky altendky mentioned this pull request Nov 14, 2024
Merged
@altendky
Copy link
Contributor Author

I was throwing it in quickly and wanted to chat with @arvidn about it specifically. Just figured it was simplest to give a concrete change to start the conversation.

Thanks for looking! (again!)

@altendky altendky marked this pull request as ready for review November 14, 2024 23:52
@altendky altendky requested a review from a team as a code owner November 14, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @aqk @arvidn