Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

# TODO: stop dropping tasks on the floor #18866

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

# TODO: stop dropping tasks on the floor #18866

wants to merge 5 commits into from
+31 −0

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 13, 2024 •
edited
Loading

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Nov 13, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@altendky altendky changed the title # TODO: stop dropping tasks on the floor # TODO: stop dropping tasks on the floor Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 14, 2024
aqk
aqk previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@aqk aqk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

wjblanke
wjblanke previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@altendky altendky dismissed stale reviews from wjblanke and aqk via 23f31e8 November 14, 2024 12:39
This was referenced Nov 14, 2024
Merged
Draft
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 14, 2024
@altendky altendky marked this pull request as ready for review November 14, 2024 23:52
@altendky altendky requested a review from a team as a code owner November 14, 2024 23:52
@altendky altendky requested a review from emlowe November 14, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke left review comments

@aqk aqk aqk left review comments

@emlowe emlowe Awaiting requested review from emlowe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @aqk @wjblanke