CHIA-1709 Pass a ValidationState to validate_unfinished_block_header #18818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
Changed
almogdepaz
reviewed
Nov 6, 2024
| @@ -43,12 +43,10 @@ def validate_unfinished_header_block( | |||
| blocks: BlockRecordsProtocol, | |||
| header_block: UnfinishedHeaderBlock, | |||
| check_filter: bool, | |||
| expected_difficulty: uint64, | |||
There was a problem hiding this comment.
this is a little confusing but the naming is important here, its actually not the current difficulty and sub slot iters but the difficulty and sub slot iters expected to be in the block, idk if maybe we should rename ValidationState params to difficulty and sub_slot_iters and add a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
validate_unfinished_block_headertakesexpected_difficulty,expected_sub_slot_itersandprev_ses_blockas separate parameters. Now that we haveValidationState, we can pass that directly.Current Behavior:
validate_unfinished_block_headertakesexpected_difficulty,expected_sub_slot_itersandprev_ses_blockas separate parameters.New Behavior:
validate_unfinished_block_headertakes aValidationStateinstead.