Scoreboard refactor #121
Merged
Scoreboard refactor #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camnwalter
force-pushed
the
scoreboard-refactor
branch
2 times, most recently
from
d3cad4e
to
d0b8530
Compare
camnwalter
force-pushed
the
scoreboard-refactor
branch
from
d0b8530
to
66133ac
Compare
Adds mutability to Scoreboard.Score among these other changes: (added unless otherwise stated) Team: - getColor - setColor Scoreboard: - addLine - createTeam - removeIndex - removeScores Scoreboard.Score: - getNumberFormat - getTeam - remove - setName - setNumberFormat - setPoints - setTeam
camnwalter
force-pushed
the
scoreboard-refactor
branch
from
66133ac
to
20617fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mutability to Scoreboard.Score among these other changes: (added unless otherwise stated)
Team:
- getColor
- setColor
Scoreboard:
- addLine
- createTeam
- removeIndex
- removeScores
Scoreboard.Score:
- getName changed to return String. made to be more consistent with other CT Apis, though could change those instead to return TextComponents
- getNumberFormat
- getTeam
- remove
- setName
- setNumberFormat
- setPoints
- setTeam
This is a big one so I will have to test this some more to make sure it's working correctly.
To do:
closes Improve the Scoreboard API #92