Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Remove multiversion, switch over to fabric loom #105

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

camnwalter
Copy link
Member

I will do some more testing to make sure everything works. Opening just to keep this on the radar.

Also I made it so it doesn't bundle fabric language kotlin or fabric api, but can revert that if it makes more sense to keep them.

Copy link
Member

@mattco98 mattco98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not sure about the API bundling. What do other mods do? Might be a good idea to avoid a loader update breaking the mod like it did with 15.3.

Also I would recommend setting your Java continuation indent setting to 4 and max line length to 120 to match my settings (can we commit that to the .idea folder somehow?). I'll probably do a project-wide format at some point so dw about it in this PR.

@camnwalter
Copy link
Member Author

camnwalter commented Jan 8, 2024

lgtm, not sure about the API bundling. What do other mods do? Might be a good idea to avoid a loader update breaking the mod like it did with 15.3.

Also I would recommend setting your Java continuation indent setting to 4 and max line length to 120 to match my settings (can we commit that to the .idea folder somehow?). I'll probably do a project-wide format at some point so dw about it in this PR.

Added the .idea/codeStyles folder. Are there any other settings you see that should also be added?

As for including/excluding fabric api, the fabric example mod doesn't include it so a lot of mods will keep it as just modImplementation. Also not really sure what caused the loader update to break ct so I can't guarantee this will be any different. Perhaps moving from essential's loom would make the compatibility better?

Edit: Loom 1.5 added a getMinecraftVersion helper so we can keep the Minecraft version in the jar name if we want.

@camnwalter camnwalter force-pushed the remove-multiversion branch 2 times, most recently from 3dcbca7 to 8381ede Compare January 9, 2024 20:48
@mattco98
Copy link
Member

Added the .idea/codeStyles folder. Are there any other settings you see that should also be added?

Nah that's fine

As for including/excluding fabric api, the fabric example mod doesn't include it so a lot of mods will keep it as just modImplementation. Also not really sure what caused the loader update to break ct so I can't guarantee this will be any different. Perhaps moving from essential's loom would make the compatibility better?

No clue, but if the loader is small (which I assume it is), then I don't really see any reason not to include it.

@camnwalter
Copy link
Member Author

No clue, but if the loader is small (which I assume it is), then I don't really see any reason not to include it.

Looking around fabric discord, I'm not entirely sure on the specifics but that seems like a bad idea.

Copy link
Member

@DJtheRedstoner DJtheRedstoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 actions workflows should be updated to include gradle/*.versions.toml in the cache key hash for proper cache invalidation.

@mattco98 mattco98 merged commit 05b533d into ChatTriggers:main Jan 18, 2024
1 check passed
@camnwalter camnwalter deleted the remove-multiversion branch January 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants